Fix incorrect rendering in nested children#3497
Open
AnnMarieW wants to merge 2 commits intoplotly:devfrom
Open
Fix incorrect rendering in nested children#3497AnnMarieW wants to merge 2 commits intoplotly:devfrom
AnnMarieW wants to merge 2 commits intoplotly:devfrom
Conversation
Member
|
@T4rk1n @AnnMarieW I see performance risks:
Can we mitigate these issues or does this need to be an optional rendering config? |
Collaborator
Author
|
Here's an interesting bit of data. The example above works fine in Dash 4 ( using the new dcc date picker), but does not work in Dash 3. One more clue: In Dash 3, if the children are wrapped in a div instead of just being a list, it updates correctly: children=html.Div([ # This line changed
dcc.DatePickerSingle(id="date-picker", date=None),
html.Span(
f"Nothing picked, {refresh_count} refreshes",
id="text",
style={
"marginLeft": "10px",
"backgroundColor": "#d0d0d0",
"padding": "5px",
},
),
]), |
Collaborator
Author
|
I expect this PR should be closed in favor of #3570 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3330
Note -this solution was provided by a Dash Enterprise customer. 🎉
In sample dash app below, a callback updates the children component with a layout of nested components. If there is a change in one of the nested components there can be unexpected results.
For example, if you select a date in the date picker, then "refresh" the layout in a callback, it re-renders the old state when you interact with the date picker again. This error happens in Dash 3 but not in Dash 2.
A workaround is to give the layout's parent component an id that changes with each update. This forces the component to re-render correctly.
This PR makes that workaround unnecessary. It updates the reducer in the dash renderer so it clears out the child path hashes and prevents stale values from triggering incorrect renders
Potential issues: